Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update runtime for ROCm6.0 (SWDEV-434155) #38

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Update runtime for ROCm6.0 (SWDEV-434155) #38

merged 6 commits into from
Dec 1, 2023

Conversation

AdrianAbeyta
Copy link

@AdrianAbeyta AdrianAbeyta commented Nov 28, 2023 •
edited
Loading

This PR enables CuPy to use the updated API's in hip/cupy_hip_runtime.h for ROCm6.0.

@AdrianAbeyta AdrianAbeyta changed the title Update runtime for ROCm6.0 (SWDEV-434155) [WIP] Update runtime for ROCm6.0 (SWDEV-434155) Nov 28, 2023
@AdrianAbeyta AdrianAbeyta changed the title [WIP] Update runtime for ROCm6.0 (SWDEV-434155) Update runtime for ROCm6.0 (SWDEV-434155) Nov 29, 2023
lcskrishna
lcskrishna approved these changes Nov 29, 2023
View reviewed changes
Copy link

@lcskrishna lcskrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ideally this change shouldn't affect anything in the master branch.

pnunna93
pnunna93 approved these changes Nov 29, 2023
View reviewed changes
Copy link

@pnunna93 pnunna93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amathews-amd
amathews-amd approved these changes Nov 30, 2023
View reviewed changes
Copy link

@amathews-amd amathews-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bmedishe
bmedishe reviewed Dec 1, 2023
View reviewed changes
Copy link

@bmedishe bmedishe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All UTs pass except for 1486 failed : tests/cupyx_tests/scipy_tests/signal_tests which are seen failing in master branch too

@AdrianAbeyta AdrianAbeyta merged commit 432a868 into master Dec 1, 2023
11 checks passed
@lcskrishna
Copy link

Passing log:
https://amdcloud-my.sharepoint.com/:u:/g/personal/csrikris_amd_com/EU4ofnSXhulHkls1k-G6geUBFOiHy2nVh3swfyglRS62_w?e=ucYqhn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmedishe bmedishe bmedishe left review comments

@pnunna93 pnunna93 pnunna93 approved these changes

@amathews-amd amathews-amd amathews-amd approved these changes

@lcskrishna lcskrishna lcskrishna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AdrianAbeyta @lcskrishna @amathews-amd @bmedishe @pnunna93 @kmaehashi