Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hip solver lazy loading #34

Merged
merged 18 commits into from
Nov 22, 2023

Conversation

bmedishe
Copy link

@bmedishe bmedishe commented Nov 6, 2023

No description provided.

@bmedishe bmedishe self-assigned this Nov 10, 2023
@lcskrishna
Copy link

@bmedishe Could you run pre-commit run --all-files in your local setup and fix all the flake8 or any coding standard issues. This will clear static-tests CI failures.

@lcskrishna
Copy link

For ROCm builds, could you please cherry-pick or port these changes into your PR.
https://github.com/ROCmSoftwarePlatform/cupy/pull/18/files#diff-def21d65b1bcf0fdd594272d80964de16c0b7d8bffbebd488839499b874a63f4

@bmedishe
Copy link
Author

For ROCm builds, could you please cherry-pick or port these changes into your PR. https://github.com/ROCmSoftwarePlatform/cupy/pull/18/files#diff-def21d65b1bcf0fdd594272d80964de16c0b7d8bffbebd488839499b874a63f4

Thank you Chaitanya @lcskrishna , I updated PR for the above comments

@lcskrishna
Copy link

@bmedishe Let's re-run the whole test suite again with the newer changes and attach the passing log here. This way we can identify if there are any regressions early on since we are moving to the newer design.

Copy link

@AdrianAbeyta AdrianAbeyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdrianAbeyta AdrianAbeyta merged commit c64d3c1 into rocm6.1_internal_testing Nov 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants