Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base class for gtests #3135

Open
CAHEK7 opened this issue Jul 23, 2024 · 1 comment
Open

Add base class for gtests #3135

CAHEK7 opened this issue Jul 23, 2024 · 1 comment
Assignees
Labels

Comments

@CAHEK7
Copy link
Contributor

CAHEK7 commented Jul 23, 2024

Gtests are using random generator and setting internal library state based on environmental variables. It may work for a case single binary-single test, but will not work for a single binary-all the tests case since the tests will interfere each other and the behavior will be heavily dependent on the test order.

We need a base class for gtests, which will cover resetting prng at the beginning of the tests (trivial, by adding prng::reset_seed(); in the constructor) and handling consistent environmental variable state but saving and restoring full state of the updated env variables (including isSet/isUset state).

@reidkwja
Copy link
Contributor

reidkwja commented Oct 18, 2024

currently addressed in #3321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants