Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hipblaslt_ext::getAllAlgos returns solutions, none of which are supported #3713

Open
ahsan-ca opened this issue Dec 13, 2024 · 2 comments
Open
Assignees

Comments

@ahsan-ca
Copy link
Contributor

hipblaslt_ext::getAllAlgos returns algos which can then be validated using hipblaslt_ext::matmulIsAlgoSupported. For some cases, all the algos returned are invalid.

This seems to be an issue that hipBLASLt team needs to look into. Collect such cases and logs for hipBLASLt team to look into.

@ahsan-ca ahsan-ca self-assigned this Dec 13, 2024
@ahsan-ca ahsan-ca changed the title hipblaslt_ext::getAllAlgos returns algos none of which are supported hipblaslt_ext::getAllAlgos returns solutions, none of which are supported Dec 18, 2024
@ahsan-ca
Copy link
Contributor Author

ahsan-ca commented Dec 18, 2024

Observation of investigation:

  • On bert-base-cased, we hit the issue of getAllAlgos() returning all invalid solutions, only when we disable MLIR. With MLIR enabled, we do not hit this issue.

I have opened a ticket for this issue against hipBLASLt.

@ahsan-ca
Copy link
Contributor Author

Feedback from the hipBLASLt team:

This is a standard behavior. getall means to get all the solutions, and when that solution is valid
for a certain size, checked by issuppoted then call matmul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant