This repository has been archived by the owner on Jan 20, 2024. It is now read-only.
[OMPIRBuilder] Improve type handling for kmpc_for_static_loop #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 4 variants to this new RTL function:
- kmpc_for_static_loop_4: 4-byte, signed
- kmpc_for_static_loop_4u: 4-byte, unsigned
- kmpc_for_static_loop_8: 8-byte, signed
- kmpc_for_static_loop_8u: 8-byte, unsigned
This patch aims at using the type of the trip count variable to select the
appropriate variant of this RTL function, rather than always calling the signed
4-byte version and possibly truncating the trip count. It's based on
`getKmpcForDynamicInitForType()` and other similar helper functions, which
result always in codegen for the unsigned variants of the function.
A small bug, which produces a compiler crash when a target worksharing loop
construct does not capture outside variables, is also addressed. This example
would trigger this bug:
```
subroutine foo()
!$omp target parallel do
do i = 1, 10
call bar(i)
end do
!$omp end target parallel do
end subroutine
```
|
Closing due to being replaced by #240. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 4 variants to this new RTL function:
This patch aims at using the type of the trip count variable to select the appropriate variant of this RTL function, rather than always calling the signed 4-byte version and possibly truncating the trip count. It's based on
getKmpcForDynamicInitForType()and other similar helper functions, which result always in codegen for the unsigned variants of the function.A small bug, which produces a compiler crash when a target worksharing loop construct does not capture outside variables, is also addressed. This example would trigger this bug: