States in 10_SD_Rojaflex not perfect

[Hofyyy]

Expected Behavior

• If the shutter is already open and I press in FHEM: Stop or open, state should stay open
• If the shutter is already open and I press on the remote: Stop or open, state should stay open
• same for close

So states in pos 0 or 100 are not ideal in special case.

[Hofyyy]

I would need some help for a review and checking why its not compiling. :-/

[sidey79]

There are some tests failing:

/home/runner/work/RFFHEM/RFFHEM/t/FHEM/10_SD_Rojaflex/01_set.t (Wstat: 1024 Tests: 24 Failed: 4) Failed tests: 17, 19, 22, 24 Non-zero exit status: 4 /home/runner/work/RFFHEM/RFFHEM/t/FHEM/10_SD_Rojaflex/09_parseData.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1

[sidey79]

To be more detailed we have to check the log:

https://github.com/RFD-FHEM/RFFHEM/actions/runs/12837082669/job/35800028924#step:7:14689

Which has some not ok marked tests:

not ok 17 - Protocol 109 - set SD_Rojaflex_Test_0 stop (channel 0) {
    1..3
    ok 1 - check return is undef
    not ok 2 - check reading for devices
    not ok 3 - check reading for devices
}

not ok 19 - Protocol 109 - set SD_Rojaflex_Test_0 gotofav (channel 0) {
    1..3
    ok 1 - check return is undef
    not ok 2 - check reading for devices
    not ok 3 - check reading for devices
}

And we can find even some more details what causes the failing tests

ok 1 - 10_SD_Rojaflex loaded
ok
    # Failed test 'check reading for devices'
    # at /home/runner/work/RFFHEM/RFFHEM/t/FHEM/10_SD_Rojaflex/01_set.t line 127.
    # +--------+----+-------+
    # | GOT    | OP | CHECK |
    # +--------+----+-------+
    # | closed | eq | stop  |
    # +--------+----+-------+
    (If this table is too small, you can use the TABLE_TERM_SIZE=### env var to set a larger size, detected size is '74')

    # Failed test 'check reading for devices'
    # at /home/runner/work/RFFHEM/RFFHEM/t/FHEM/10_SD_Rojaflex/01_set.t line 128.
    # +--------+----+-------+
    # | GOT    | OP | CHECK |
    # +--------+----+-------+
    # | closed | eq | stop  |
    # +--------+----+-------+
    (If this table is too small, you can use the TABLE_TERM_SIZE=### env var to set a larger size, detected size is '74')


# Failed test 'Protocol 109 - set SD_Rojaflex_Test_0 stop (channel 0)'
# at /home/runner/work/RFFHEM/RFFHEM/t/FHEM/10_SD_Rojaflex/01_set.t line 129.
    # Failed test 'check reading for devices'
    # at /home/runner/work/RFFHEM/RFFHEM/t/FHEM/10_SD_Rojaflex/01_set.t line 127.
    # +----------+----+---------+
    # | GOT      | OP | CHECK   |
    # +----------+----+---------+
    # | clearfav | eq | gotofav |
    # +----------+----+---------+
    (If this table is too small, you can use the TABLE_TERM_SIZE=### env var to set a larger size, detected size is '74')

    # Failed test 'check reading for devices'
    # at /home/runner/work/RFFHEM/RFFHEM/t/FHEM/10_SD_Rojaflex/01_set.t line 128.
    # +----------+----+---------+
    # | GOT      | OP | CHECK   |
    # +----------+----+---------+
    # | clearfav | eq | gotofav |
    # +----------+----+---------+
    (If this table is too small, you can use the TABLE_TERM_SIZE=### env var to set a larger size, detected size is '74')


# Failed test 'Protocol 109 - set SD_Rojaflex_Test_0 gotofav (channel 0)'
# at /home/runner/work/RFFHEM/RFFHEM/t/FHEM/10_SD_Rojaflex/01_set.t line 129.
    # Failed test 'check reading for device'
    # at /home/runner/work/RFFHEM/RFFHEM/t/FHEM/10_SD_Rojaflex/01_set.t line 148.
    # +--------+----+-------+
    # | GOT    | OP | CHECK |
    # +--------+----+-------+
    # | closed | eq | stop  |
    # +--------+----+-------+
    (If this table is too small, you can use the TABLE_TERM_SIZE=### env var to set a larger size, detected size is '74')


# Failed test 'Protocol 109 - set SD_Rojaflex_Test_09 stop (channel 0)'
# at /home/runner/work/RFFHEM/RFFHEM/t/FHEM/10_SD_Rojaflex/01_set.t line 149.
    # Failed test 'check reading for device'
    # at /home/runner/work/RFFHEM/RFFHEM/t/FHEM/10_SD_Rojaflex/01_set.t line 148.
    # +----------+----+---------+
    # | GOT      | OP | CHECK   |
    # +----------+----+---------+
    # | clearfav | eq | gotofav |
    # +----------+----+---------+
    (If this table is too small, you can use the TABLE_TERM_SIZE=### env var to set a larger size, detected size is '74')


# Failed test 'Protocol 109 - set SD_Rojaflex_Test_09 gotofav (channel 0)'