Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biotransformer: error from having mixtures as input #393

Open
ElliottJP opened this issue Jul 25, 2023 · 5 comments
Open

Biotransformer: error from having mixtures as input #393

ElliottJP opened this issue Jul 25, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@ElliottJP
Copy link
Member

Biotransformer outputs misaligned - errors with e.g. random " additions.
Galaxy history: https://umsa.cerit-sc.cz/u/elliott/h/columbiabootcamp2

@ElliottJP ElliottJP added the bug Something isn't working label Jul 25, 2023
@xtrojak
Copy link
Contributor

xtrojak commented Jul 25, 2023

@ElliottJP the actual error seems to be caused by incorrect input:

...
Working on compound: [Na+].[Na+].NC1=NC(=O)N(C=C1)[C@@H]2O[C@H](CO[P]([O-])(=O)O[P](O)(=O)O[P](O)([O-])=O)[C@@H](O)[C@H]2O
ERROR: Input compound cannot be a mixture.

@hechth
Copy link
Member

hechth commented Aug 1, 2023

@ElliottJP seems like biotransformer would also require removing salts from the inputs?

@hechth hechth changed the title Biotransformer Biotransformer: error from having mixtures as input Aug 1, 2023
@hechth
Copy link
Member

hechth commented Nov 16, 2023

This should be discussed with the package developers.

@hechth
Copy link
Member

hechth commented Nov 16, 2023

We agreed that this issue should be reported upstream and will not be fixed on this side with regard to havign mixtures in the list of SMILES. This will be solved separately.

We will investigate the output misalignment in this issue only and report the error upstream.

biotransformer_outputs.zip

@hechth
Copy link
Member

hechth commented Nov 16, 2023

xref for mixture filtering: #430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants