From 4414e840c71e9fb1f5b41b4eb8c43424be25ec54 Mon Sep 17 00:00:00 2001
From: ewelinagr <ewelina@thehyve.nl>
Date: Wed, 11 Dec 2024 17:00:02 +0100
Subject: [PATCH] Fix default password for minio.

Minio won't start if the password length is less than 9 characters.
---
 bin/generate-secrets  | 4 ++--
 etc/base-secrets.yaml | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/bin/generate-secrets b/bin/generate-secrets
index f05dfc8c8..778f0b79a 100755
--- a/bin/generate-secrets
+++ b/bin/generate-secrets
@@ -64,8 +64,8 @@ nginx_auth_password=$(generate_secret)
 secret="thehyve:$(echo $nginx_auth_password | openssl passwd -apr1 -stdin)" insert_secret ".kube_prometheus_stack.nginx_auth"
 comment="username: thehyve, password: $nginx_auth_password" yq -i ".kube_prometheus_stack.nginx_auth line_comment |= strenv(comment)" etc/secrets.yaml
 
-# Generate secrets for all remaining fields with value 'secret'.
-replacements=$(yq e '.. | select(. == "secret") | [(path | "."+join("."))] | join(" ")' etc/secrets.yaml);
+# Generate secrets for all remaining fields with value 'secret' or 'secret-secret' (if the component has a min length requirement).
+replacements=$(yq e '.. | select(. == "secret" or "secret-secret") | [(path | "."+join("."))] | join(" ")' etc/secrets.yaml);
 for key in $replacements; do
   insert_secret $key
 done
\ No newline at end of file
diff --git a/etc/base-secrets.yaml b/etc/base-secrets.yaml
index 627cd2aee..e10766864 100644
--- a/etc/base-secrets.yaml
+++ b/etc/base-secrets.yaml
@@ -147,9 +147,9 @@ radar_integration:
 
 # --------------------------------------------------------- 20-s3-connector.yaml ---------------------------------------------------------
 # The access keys and secret keys of object storage services should match.
-# If AWS S3 is used as a storage medium instead of minio, then fill in those.
-s3_access_key: secret
-s3_secret_key: secret
+# For minio those values need to have at least 8 characters
+s3_access_key: secret-secret
+s3_secret_key: secret-secret
 
 # --------------------------------------------------------- 20-upload.yaml ---------------------------------------------------------
 radar_upload_postgres_password: secret