Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calc_WodaFuchs2008() deserves more attention #223

Open
mcol opened this issue Sep 9, 2024 · 1 comment
Open

calc_WodaFuchs2008() deserves more attention #223

mcol opened this issue Sep 9, 2024 · 1 comment

Comments

@mcol
Copy link
Contributor

mcol commented Sep 9, 2024

From #197:

  • The curvature will be infinite if the 1st and 3rd bin have the same count (which is not a remote possibility) as it divides by counts_log[1] - counts_log[3]
  • It's unclear why we should only use the first 3 elements of count_log, as if the user sets a large number of histogram breaks, then count_log will be much longer than 3
  • At the end of the day, it doesn't quite matter as curvature is never used anywhere in the code after it's computed!
  • There is a minimum number of breaks set at 4 which seems somewhat arbitrary, in particular if the curvature computation is unused

Moreover:

  • Should the function add the data slot to the RLum.Results object it produces?
@RLumSK RLumSK added this to the Release version 1.0.0 milestone Sep 9, 2024
@RLumSK
Copy link
Member

RLumSK commented Sep 9, 2024

@mcol We should have a look together after the 0.9.25 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants