Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov.io page doesn't get updates #144

Open
mcol opened this issue Aug 15, 2024 · 2 comments
Open

codecov.io page doesn't get updates #144

mcol opened this issue Aug 15, 2024 · 2 comments
Labels
bug (reverse import) Bug in an external package

Comments

@mcol
Copy link
Contributor

mcol commented Aug 15, 2024

Looking at the codecov.io page for the dev_0.9.x branch the last commit recorded there goes back to 3 months ago. From the most recent github test-coverage results the "Upload test results" step is not run. Also, if you unfold the "Test coverage" line, at the very bottom it says:

[1] "Could not find a repository associated with upload token ***"

I'm not sure how to further debug this

RLumSK added a commit that referenced this issue Aug 15, 2024
Hopefully it fixes the token issue (see also JohnGavin/hellow@985c34a)
@mcol
Copy link
Contributor Author

mcol commented Aug 15, 2024

The latest coverage run took 1h 12m but at the end it still failed to upload the tests, this time with some additional printouts:

Request failed [404]. Retrying in 1.8 seconds...
Request failed [404]. Retrying in 1 seconds...
$detail
[1] "Could not find a repository associated with upload token ***"

I've tried running all tests with coverage locally and it took only 4 minutes. Perhaps the github action also runs the examples? But those would be flagged by CRAN if they took more than a couple of minutes, so it's unlikely that they are causing the long execution time.

@RLumSK
Copy link
Member

RLumSK commented Aug 15, 2024

I've managed to run the coverage test including the upload with token stored as GitHub secret locally and upload the results. I will further investigate why the run takes that long.

Updates

  • I've run all tests locally using testthat::test_local(). This takes somewhat 90 s to 100 s on my machine and it can be excluded as an issue. It remains interesting.
  • I've removed all tests and ran covr::package_coverage(type = "tests") locally and still got stuck for minutes after the package was built. I interrupted the task; conclusion: it has nothing to do with the tests.
  • After I had reset the token, now the upload works at least, just the time issue is still pending
  • I've now tried to run the coverage without checking the compiled code: no difference

More through tests

Local tests use the following code lines:

Sys.setenv(NOT_CRAN = "true")
system.time(x <- covr::package_coverage(type = "tests"))

GitHub Action test runs

OS R Version COVR VERSION RUNTIME TEST COVERAGE SUCCESS LINK
ubuntu-22.04 4.3.3 3.6.4 6:28 min TRUE URL
ubuntu-22.04 4.4.1 3.6.4 79:19 min TRUE URL
ubuntu-22.04 (2024-08-17 r87027) 3.6.4 80:00 min TRUE URL

Other observations

  • 'RCarb' does not have this problem URL

@RLumSK RLumSK added the bug Clear problem or crash label Aug 20, 2024
@RLumSK RLumSK added bug (reverse import) Bug in an external package and removed bug Clear problem or crash labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug (reverse import) Bug in an external package
Projects
None yet
Development

No branches or pull requests

2 participants