-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛] Qwik DOM testing package currently coupled to Qwik Router #31
Comments
Of course! This has been the ultimate goal since I first started playing with Astro. (before I knew Qwik even existed)
It's because the service worker is disabled in dev mode (and speculative module fetching) This makes sure dev mode is never stale.
Yeah this blog post came out when Qwik City was the only meta-framework option for Qwik. I would follow Astro's vitest guide and example: Qwik City is an alternative to Astro. It's similar to what Next.js is to React for example. They are incompatible. |
@thejackshelton I actually did follow those two links you provided and did not have any luck. Let me create a reproduction. The astro vitest does not have DOM tests, and the testing documentation is very barebones on if it is actually working or not. Pleas check this reproduction, Here Running test will fail for DOM and running build will also fail with lots of warnings and error at end. |
I'm a bit confused, does it work without the It looks like this reproduction does not include the integration and breaks, if that's the case, it'd probably be better to copy the conversation link here and include your reproduction in the Astro repository or the Astro vitest integration repo. |
@thejackshelton Sorry for some reason the link was just the template not the repro, Here is the repo 🙇 Running build or test (simplest way is useing this dropdown) will error in slightly different ways described above. |
🙇 |
Hey will try to figure out what to do here, but it looks like that can't be achieved without externally touching the @builder.io/qwik/testing package, and figuring out how to extract out the qwikCity plugin from the package. |
I am also running into the same problem in this repo. Brand new template did the same steps as shown in the video where Steve announced it a month ago. Only differences that may be affecting it is using Astro 4.0. Getting this output |
Yeah I'm gonna try to tackle this tomorrow, although I think the challenging part is this seems to be something tied to Qwik City 😬 . Will see if there's an astro way of doing this first and then circle back to what we can do there. Thanks for being patient guys and appreciate raising awareness on this issue! |
Hey y'all! I know this issue has been up for ages (the longest in this integration) This package is intended for the Qwik core team, instead please use https://github.com/ianlet/qwik-testing-library |
First thanks for working on this integration, it is super interesting to play with the integration of multi awesome concepts for making the web faster and better.
Please let me know if this is not related at all to this integration, throughout troubleshooting it seems to only affect astro template so far.
I am trying to setup Vitest with it to enable some unit testing.
I have attempted to setup Vitest with the following steps that are outlined in a blog here It however uses qwik city and vite instead.
npm i vitest --save-dev
vitest.config.ts
with the followingExpected outcome: (from the qwik city example)
Also as a bonus does anyone know why it has these warnings for performance?
Actual Outcome:
Any information on this would be awesome, I struggled finding any information on this through some searches. 🙇
Extra
When trying to build it happens to do this as well
The text was updated successfully, but these errors were encountered: