Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry Desync when connecting to server #115

Open
Noaaan opened this issue Aug 3, 2023 · 0 comments
Open

Registry Desync when connecting to server #115

Noaaan opened this issue Aug 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Noaaan
Copy link

Noaaan commented Aug 3, 2023

There is some weird behaviour in Quilt environments where registering blocks in a certain way causes a registry desync. This has not been reported in any capacity in a Fabric environment, and has happened a couple of times during the Blanketcon pack development.

This only manifests sometimes when launching and connecting to a server. It is somewhat hard to reproduce, which points to it being some sort of race condition. Only log entry which seems out-of-place is the following line:

[Render thread/WARN] (Quilted Fabric Content Registries) An unregistered entry on the Registry[ResourceKey[minecraft:root / minecraft:block] (Stable)] registry was attempted to be registered in a content registry through the Quilted Fabric API bridge! Its instability will be circumvented through the activation of the registry's deferring queue, which may affect performance!

When the bridge is triggered the desync seems to happen every time. I am having a very hard time reproducing the issue, but I have had it happen once myself.

For some context; Alloy Forgery has an unique registry system where data is read before registration, and a RegistryEntryAddedCallback event is registered for specified blocks in order to register Forge Controllers once the game launches. This essentially allows you to create custom Alloy Forges using data.

Code for context:
Alloy Forgery - ForgeDefinition class, creates the event
owo-lib - ComplexRegistryAction, schedules the event

Mods in question:
Mythic Metals 0.18.2+1.20
Alloy Forgery 2.0.22+1.20
owo-lib 0.11.1+1.20

Logs from the event (provided by jamalam):
Client: https://mclo.gs/h1aqcjO
Server: https://mclo.gs/NY2QLro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants