Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gradle home cache for Minecraft libraries #492

Closed
IotaBread opened this issue Sep 7, 2023 · 3 comments · Fixed by #645
Closed

Use gradle home cache for Minecraft libraries #492

IotaBread opened this issue Sep 7, 2023 · 3 comments · Fixed by #645
Labels
enhancement new feature or request t: toolchain changes to the quilt mappings toolchain

Comments

@IotaBread
Copy link
Member

Storing the Minecraft libraries in the home cache would reduce wait times and disk usage greatly when managing two or more clones of the repository, instead of downloading them on each copy of QM.

@IotaBread IotaBread added enhancement new feature or request t: toolchain changes to the quilt mappings toolchain labels Sep 7, 2023
@OroArmor OroArmor assigned OroArmor and unassigned OroArmor Sep 9, 2023
@supersaiyansubtlety
Copy link
Member

@lukebemish would putting @CachableTask on the task that downloads the libraries achieve basically the same result as putting them in the global .gradle cache?

@lukebemish
Copy link

lukebemish commented Nov 19, 2024

CacheableTask only matters if build cache is on. If the goal is just not re-downloading anything, you shouldn't have to do anything -- normal old up-to-date checks should be enough. If the goal is sharing between different cloned copies of the repo -- use CacheableTask and enable build cache, yeah. Custom caching in the gradle home directory is very hard to do correctly in a way that doesn't lead to locking issues.

@supersaiyansubtlety
Copy link
Member

Great, #645 already enabled build cache, I’ll just make sure the download libraries task works with CacheableTask.

@supersaiyansubtlety supersaiyansubtlety linked a pull request Nov 20, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature or request t: toolchain changes to the quilt mappings toolchain
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants