Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nimble 14: Fix broken tests in swift 6 #1169

Closed
wants to merge 30 commits into from
Closed

Nimble 14: Fix broken tests in swift 6 #1169

wants to merge 30 commits into from

Conversation

younata
Copy link
Member

@younata younata commented Oct 14, 2024

The PR should summarize what was changed and why. Here are some questions to
help you if you're not sure:

  • What behavior was changed?
  • What code was refactored / updated to support this change?
  • What issues are related to this PR? Or why was this change introduced?

Checklist - While not every PR needs it, new features should consider this list:

  • Does this have tests?
  • Does this have documentation?
  • Does this break the public API (Requires major version bump)?
  • Is this a new feature (Requires minor version bump)?

younata added 25 commits October 13, 2024 19:58
@younata
Make AsyncExpression conform to Sendable (#1067)
47e7f75
@younata
Make expect for async closures take in Sendable closures (#1070)
7c66a9f
@younata
The async variants of expect now require Sendable values (#1071)
a3301f0
@younata
Make AsyncPredicate Sendable and operate only on Sendable types (#1072)
63743e7 
Make Predicate's closure Sendable, and make Predicate Sendable when the returning value is Sendable
@younata
Update Require DSL to be (mostly) Sendable. (#1130)
48d606f 
* Update Require DSL to largely be Sendable

* Fix now-broken tests
@younata
Make FailureMessage sendable. (#1131)
8b5e280
@younata
Make MatcherResult conform to Sendable (#1132)
696e860 
* Make FailureMessage sendable.

* Make MatcherResult conform to Sendable
@younata
Make the Polling Helpers Sendable (#1133)
bde016a
@younata
Make AssertionHandler Sendable (#1141)
a321e37
@younata
Mark the protocol conformances in BeLogical as retroactive
5beb29e
@younata
Mark the synchronous DSL funcs as sending
8b75e85
@younata
Mark values in AsyncExpression as sending
c60c441
@younata
Reimplement MemoizedClosure to avoid the actor reentrant problem
3abba9d
@younata
Mark the closures in AsyncExpression as sending
be285e2
@younata
Update the PostNotification matcher to be sendable
49c8316
@younata
Update the BeResult matchers to take in sendable closures
01b1ed5
@younata
Update the Map matchers to take in sendable closures
5cd0493
@younata
Update the waitUntil DSL to be sendable... ish
b504403 
Still more to do here. Will likely to require further refactoring
@younata
Make NMBMatcher unchecked sendable
599568b 
There are 2 subclasses which are also sendable/safe to use. And no one else can make subclasses outside of Nimble, so this is tolerable
@younata
Mork work on getting the async-version of polling expectations to be …
27cef92 
…compatible with swift 6
@younata
Eliminate concurrency warnings in polling expectations
322f9be
@younata
Fix concurrency warnings for more objective-c/foundation types (#1165)
b4b2dad
@younata
Fix the current set of concurrency warnings in tests (#1166)
ff61b40
@younata
All parts of the dsl must take in sending (#1167)
9c13be6
@younata
Remove usage of the swift 6 only sending keyword (#1168)
7a336bb
@younata younata mentioned this pull request Oct 14, 2024
Draft
1 task
@younata younata force-pushed the nimble-13-failing-tests branch from 259705b to efd7a78 Compare October 14, 2024 05:51
@younata younata force-pushed the nimble-13-failing-tests branch from 2ff6980 to d28c8ed Compare October 15, 2024 03:47
@gremlinflat
Copy link

any update for this? i've been experiencing this error on xcode 16 (swift 6)

@younata younata closed this Dec 20, 2024
@younata younata deleted the nimble-13-failing-tests branch December 20, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@younata @gremlinflat