Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor InfiniteEnvironments and GradientGrassmann #224

Merged
merged 21 commits into from
Jan 14, 2025
Merged

Conversation

lkdvos
Copy link
Member

@lkdvos lkdvos commented Jan 8, 2025

This PR consists of a number of changes that ultimately boil down to removing the automated recomputation of the infinite environments.

In order to achieve this, a number of additional changes are also included:

  • most notably, I finally got around to cleaning up the grassmann implementation, which now uses the preconditioner in OptimKit. This GREATLY improves the clarity, and should hopefully be a nice change for future development.
  • all infinite environments are now unified
  • various utility changes
  • various preparatory changes for having above and below different.

Copy link

codecov bot commented Jan 8, 2025

@lkdvos lkdvos force-pushed the infiniteenvs branch 4 times, most recently from a0d964d to 8421f45 Compare January 9, 2025 00:35
@lkdvos lkdvos force-pushed the infiniteenvs branch 2 times, most recently from 55c4765 to f816aac Compare January 10, 2025 18:08
@lkdvos
Copy link
Member Author

lkdvos commented Jan 10, 2025

While debugging the approximate methods, I would say that we really need to have a proper look at choosing a convention for above and below, since now this is somehow different for the approximate methods compared to the leading_boundary methods... This also ties together with a proper debug of the whole Multiline machinery

@lkdvos lkdvos force-pushed the infiniteenvs branch 2 times, most recently from b3d11e1 to 53a1019 Compare January 10, 2025 19:16
@lkdvos
Copy link
Member Author

lkdvos commented Jan 10, 2025

LTS test failures might be unrelated: retrying CI on master to verify that here
EDIT: issue seems to have solved itself

@lkdvos lkdvos mentioned this pull request Jan 12, 2025
@lkdvos lkdvos enabled auto-merge (squash) January 13, 2025 16:39
@lkdvos lkdvos disabled auto-merge January 13, 2025 16:39
@lkdvos lkdvos enabled auto-merge (rebase) January 13, 2025 16:40
@lkdvos lkdvos disabled auto-merge January 14, 2025 20:41
@lkdvos lkdvos merged commit b273833 into master Jan 14, 2025
28 checks passed
@lkdvos lkdvos deleted the infiniteenvs branch January 14, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants