Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce InfiniteMPOHamiltonian to be square #215

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

lkdvos
Copy link
Member

@lkdvos lkdvos commented Dec 18, 2024

After further consideration, for now the easiest solution is to enforce InfiniteMPOHamiltonian to be square. This addresses #214 .

@Gertian
Copy link
Collaborator

Gertian commented Dec 18, 2024

Fair enough.
Although this slightly lowers performance right ?

@lkdvos
Copy link
Member Author

lkdvos commented Dec 18, 2024

With the current implementation, it probably makes no difference.

@Gertian
Copy link
Collaborator

Gertian commented Dec 18, 2024

I meant towards an optimal implementation that considers this.

But in any case the main cost (which is the linear problem right ?) is probably mostly left unaltered ?

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/operators/mpohamiltonian.jl 80.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/operators/mpohamiltonian.jl 90.72% <80.00%> (+0.49%) ⬆️

... and 1 file with indirect coverage changes

@lkdvos lkdvos merged commit e8098f6 into master Dec 18, 2024
26 of 28 checks passed
@lkdvos lkdvos deleted the square-operators branch December 18, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants