Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decimal place logic should actually be in the contract, not in the sdk #3

Open
EdoardoPona opened this issue May 15, 2021 · 0 comments

Comments

@EdoardoPona
Copy link
Contributor

This is because the contracts are the ones minting the voting tokens to the users. Currently the only way of minting the correct amount for users is to also manipulate the asset_coefficient in the sdk (multiply by 10^n where n is the number of decimal places). This sdk then also has to handle "hiding" this from the sdk user, this is ugly, and someone who (for some reason) is using the contracts without the sdk will find it confusing. The number of decimal places could either be fixed, or passed in as a parameter at creation (probably hidden away by the sdk)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant