Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validacion para prevenir seleccionar a participantes ya premiados #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Validacion para prevenir seleccionar a participantes ya premiados #40

wants to merge 1 commit into from

Conversation

JoseAVallejo12
Copy link

@JoseAVallejo12 JoseAVallejo12 commented Oct 27, 2024 •
edited by pyjavo
Loading

Cambios realizados

  1. Se crean unit test para la funcion winner.
  2. Se agregan validaciones de datos.
  3. Agrego logica para prevenir premios a participantes ya premiados.
  4. Se agrega la Doc de cada funcion
  5. Se agregan validaciones y manejo de errores para las funciones winner y get_reward
  6. Se crean los tipo de datos Participant y Reward para las entradas de datos desde csv

Closes #30

@JoseAVallejo12
feat: se crean unit test para la funcion winner, se agregan validacio…
2b91733 
…nes de datos, y se agrega logica para prevenir premios a participantes ya premiados
@JoseAVallejo12 JoseAVallejo12 mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Unitario: El ganador debe salir del listado de asistentes para no volver a participar del sorteo
2 participants
@JoseAVallejo12 @pyjavo