Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubSystemContext scaladocs out of date #793

Open
davesmith00000 opened this issue Nov 26, 2024 · 2 comments
Open

SubSystemContext scaladocs out of date #793

davesmith00000 opened this issue Nov 26, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@davesmith00000
Copy link
Member

...following all the context rework. Better check the other context types too...

@davesmith00000 davesmith00000 added the good first issue Good for newcomers label Nov 26, 2024
@Ankush1oo8
Copy link

What to do in this can you describe the problem

@davesmith00000
Copy link
Member Author

Hi @Ankush1oo8,

Certainly, sorry I hadn't expected anyone to look into this before I did. 🙂

Work has just been done refactoring the type that used to be called FrameContext (and relatedly SceneContext and SubSystemContext, ... I think that's it? Is there one for Physics too?) into a type simply called Context, and its constructor arguments have changed, but the in-code scaladoc comments do not reflect that, e.g. they still mention boundary locator as an argument, when it isn't there.

It's an oversight from the refactoring work but it needs to be checked and corrected.

Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants