Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

either change or remove the new simulation #9

Open
dboonz opened this issue Dec 6, 2022 · 3 comments
Open

either change or remove the new simulation #9

dboonz opened this issue Dec 6, 2022 · 3 comments
Assignees

Comments

@dboonz
Copy link
Member

dboonz commented Dec 6, 2022

The new simulation file (example_scripts/simulateData_new_notready_for_release.py) does not save any data. Otherwise it looks very nice, but we should either finish it up to a point that we can actually use it, or delete it as it's confusing at the moment.

@wfeschen can you take a look as you wrote it and either expand or delete it?

@wfeschen
Copy link
Contributor

wfeschen commented Dec 6, 2022

I will have a look at it.

@wfeschen
Copy link
Contributor

I was looking at it and figured out, that I wrote a class to simulate ptycho data (broadband, multislice and so on). However, I dont know how it ended up in ptylab. I think it makes sense to have such a class but it would take some time. I suggest creating a branch to add some functionalities for the simulation tools and delete this file on the master branch.

@dboonz
Copy link
Member Author

dboonz commented Jan 5, 2023

That sounds like a good idea. Can you do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants