Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check how regulizers are implemented #20

Open
wfeschen opened this issue Jan 2, 2023 · 1 comment
Open

Check how regulizers are implemented #20

wfeschen opened this issue Jan 2, 2023 · 1 comment
Assignees
@larsloetgering

Comments

@wfeschen
Copy link
Contributor

wfeschen commented Jan 2, 2023

At the moment almost all regularizations are applied in the function apply_constraints() which operates on the entire object and not inside the update loops of the engines. The exception is tv, which does. We have to check if this is intentional.
@dboonz
Copy link
Member

dboonz commented Jan 5, 2023

Can you take a look, lars?

It seems that at the moment we have an update rule called

``` objectPatchUpdate_TV(self, objectPatch: np.ndarray, DELTA: np.ndarray):````

This is run every 5 iterations by default when update_TV is turned on. It's changing the patch update. Is this really correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larsloetgering larsloetgering

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dboonz @wfeschen @larsloetgering