Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global fetch method impacts other SDKs #956

Open
zkxuerb opened this issue Jan 19, 2025 · 3 comments · May be fixed by #961
Open

Global fetch method impacts other SDKs #956

zkxuerb opened this issue Jan 19, 2025 · 3 comments · May be fixed by #961
Labels
bug Something isn't working

Comments

@zkxuerb
Copy link

zkxuerb commented Jan 19, 2025

Global fetch method impacts other SDKs

The Problem

The SDK calls fetch to load the wasm file, but nodejs' native fetch method cannot read the file so the global fetch method has been modified to cater for this. This affects other sdks that run in the same environment as this sdk which creates issues for certain companies to integrate Aleo using this sdk.

Potential Solution

To get around this issue the global fetch polyfill can possibly be renamed to something else, for example new_fetch(). All the current uses of fetch() within the sdk would be renamed to new_fetch().

Like this the global fetch polyfill would not impact other sdks used within the same environment.

@zkxuerb zkxuerb added the bug Something isn't working label Jan 19, 2025
@iamalwaysuncomfortable
Copy link
Collaborator

@Pauan here was the original issue mentioned.

@Pauan Pauan linked a pull request Jan 30, 2025 that will close this issue
@Pauan
Copy link
Collaborator

Pauan commented Jan 30, 2025

@zkxuerb Could you please elaborate more on what issues are happening?

@iamalwaysuncomfortable
Copy link
Collaborator

@zkxuerb to ensure this is fixed properly we'll need some extra context on the error experienced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants