Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Rectify typographical inaccuracies #75

Closed
wants to merge 5 commits into from

Conversation

nnsW3
Copy link

@nnsW3 nnsW3 commented Jun 18, 2024

This PR addresses several typographical errors across various files in the project. The changes improve readability and maintain the professional standard of the documentation and code comments.

Justification
Typographical errors, while minor, can detract from the overall quality of the project. Correcting these errors ensures clarity and professionalism, making the project more accessible and understandable for current and future contributors.

Hope it helps.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is incorrect. The simple present tense "has" would not be correct because the sentence is not stating a fact, it is expressing a necessity, requiring the subjunctive mood. The correct tense is the present subjunctive, which uses "have" even for the singular.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is incorrect. The singular is ARC, the plural is ARCs, so the correct verb is "are".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are incorrect. "Aleo instructions" is the language.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is incorrect and should be rejected. (But the description is out of date so that is a different problem.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is correct. I recommend rejecting this PR and just changing this one word.

@Suoerman108
Copy link

correct

@d0cd
Copy link
Collaborator

d0cd commented Feb 2, 2025

Closing due to relevance, correctness and activity.
Please feel free to open the PR again.

In the interest of reviewers' time, grammar and typo PRs are expected to be correct on creation.
The more impactful they are, the more slack is given to errors..

@d0cd d0cd closed this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants