Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline <script> marker detection not correctly matching when Rollup bundles the inline source and changes its contents #586

Closed
1 of 5 tasks
thescientist13 opened this issue May 2, 2021 · 0 comments · Fixed by #587
Assignees
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP v0.12.0
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

related to #572, noticed that this is till not exactly dialed in. Noticed that an existing case was working by accident.

This user code that we would feed to Rollup

// @preserve 756510913-scratch
import '@evergreen-wc/eve-container';

Was actually getting bundled by Rollup as this and thus dropping our marker

import"/lit-element.5d109b2b.js";import"/eve-container.2e10f408.js";

Because of this, the marker detection logic was only working by accident. 😞

Details

Basically our logic here be such that it should only work when marker === id which means we need to figure out an alternative marking method.

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI labels May 2, 2021
@thescientist13 thescientist13 self-assigned this May 2, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone May 2, 2021
@thescientist13 thescientist13 changed the title inline <script> marker detection not correctly matching when Rollup bundles the inline source inline <script> marker detection not correctly matching when Rollup bundles the inline source and changes its contents May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP v0.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant