Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create resuable hashing utility for Greenwood and plugins #553

Closed
2 of 8 tasks
thescientist13 opened this issue Apr 11, 2021 · 1 comment · Fixed by #760
Closed
2 of 8 tasks

create resuable hashing utility for Greenwood and plugins #553

thescientist13 opened this issue Apr 11, 2021 · 1 comment · Fixed by #760
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers Plugins Greenwood Plugins v0.24.0
Milestone
1.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented Apr 11, 2021 •
edited
Loading

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Content based file hashing is done in a variety of places in Greenwood, generating filenames based on the hashed contents of the files. Currently each implementation is doing it on its own and slightly different.

Update, as of #573 , Rollup us now the only using its own copy of hashString so I think it is just that which needs to be consolidated now

Details

It would be better to just have a single implementation that can be created in one place cli/src/libs/ that all other implementations can use, probably based on Buffer approach?
@thescientist13 thescientist13 added good first issue Good for newcomers chore unit testing, maintenance, etc Plugins Greenwood Plugins CLI labels Apr 11, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Apr 11, 2021
This was referenced Apr 25, 2021
Closed
Merged
@thescientist13 thescientist13 linked a pull request Mar 15, 2022 that will close this issue
enhancement/issue 629 cache unchanged assets in development #760
Merged
9 tasks
@thescientist13 thescientist13 mentioned this issue Mar 15, 2022
Merged
9 tasks
@thescientist13
Copy link
Member Author

I think was already done as part of #760

@thescientist13 thescientist13 added v0.24.0 enhancement Improve something existing (e.g. no docs, new APIs, etc) and removed chore unit testing, maintenance, etc labels Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers Plugins Greenwood Plugins v0.24.0
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

enhancement/issue 629 cache unchanged assets in development ProjectEvergreen/greenwood
1 participant
@thescientist13