-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5809 hedjitter #5994
base: dev
Are you sure you want to change the base?
5809 hedjitter #5994
Conversation
Signed-off-by: Ycblue <[email protected]>
Signed-off-by: Ycblue <[email protected]>
Signed-off-by: Ycblue <[email protected]>
Hi @Ycblue, |
Signed-off-by: Dr. Behrooz Hashemian <[email protected]>
for more information, see https://pre-commit.ci
Hi @Ycblue, I resolved the conflict that your PR had with the base and merged it. Please pull before making other changes and let us know if you need any help with resolving the checking errors. |
… 5809-hedjitter
Signed-off-by: Ycblue <[email protected]>
Hi @drbeh, sorry for being absent for so long. |
Hi @Ycblue, thanks for adding unit tests. May I know what this image is and what is the license for this image? |
Hi, |
@Ycblue I did not find anything specific about the license of this data but as it is release as part of the repo with Apache 2.0, I think its license should be the same. For now, maybe it's better to use the URL from their repo (https://github.com/gatsby2016/Augmentation-PyTorch-Transforms/raw/master/data/10-05074_353_49_8178.png) to write the unittests and check and verify everything works, then I can help you to either use one of existing images in monai or upload it to monai-extra-test-data. What do you think? |
Fixes #5809 .
@drbeh sorry for the long wait. Some things came inbetween and I couldn't work on the feature till now. I asked the original author of the code for permission and he added an Apache 2.0 license to his repo.
Btw, what is the correct route of communication? Should we communicate over pull requests or in the comments of the issue?
Description
Implementation of HEDJitter in MONAI framework.
The proposed transform randomly perturbes HED color space values of an RGB image.
Added HEDJitter class to
pathology.transforms.stain.array.py
Added HEDJitterd class to
pathology.transforms.stain.dictionary.py
Passed codeformat and autofix.
Still designing unit tests.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.