-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Stain Normalization #3505
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Hi @drbeh there's a discussion about rearranging the pathology modules into also do we want to keep the previous names as alias so that it's backward compatible? |
Hi @wyli, that's right! but it would make it much harder for reviewing if we combine rearranging all components and refactoring this component together. |
@wyli can we have this PR reviewed and merged? |
Hi, we haven't finished the discussions in overall design and naming convention #3868, please could you work on that first? |
Hi @wyli, I'm not sure how it is related. Can you let me know what exactly you want for this stain normalizer specifically? |
Actually, never mind! We'll review it when we are adding it to monai core. |
Description
This PR refactor stain normalization to support channel first input (instead of channel last), and modifies the code to be more readable with more meaningful names.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests
.make html
command in thedocs/
folder.