Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds a _requires_ key for ConfigComponent #3942

Closed
wyli opened this issue Mar 15, 2022 · 2 comments · Fixed by #3945
Closed

adds a _requires_ key for ConfigComponent #3942

wyli opened this issue Mar 15, 2022 · 2 comments · Fixed by #3945
Assignees
@wyli

Comments

@wyli
Copy link
Contributor

wyli commented Mar 15, 2022

Is your feature request related to a problem? Please describe.
ConfigComponent may require another config section to run beforehand, this could be denoted by

comp:
    _target_: monai.module
    _requires_: @another_section_name
@wyli wyli self-assigned this Mar 15, 2022
wyli added a commit to wyli/MONAI that referenced this issue Mar 15, 2022
@wyli
fixes Project-MONAI#3942
29243d2 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli mentioned this issue Mar 15, 2022
Merged
7 tasks
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Mar 15, 2022

Hi @wyli ,

Could you please help add / mark this ticket to #3482 ? Then we can track all the feature related tasks in #3482.

Thanks.

@wyli wyli mentioned this issue Mar 15, 2022
Closed
17 tasks
@wyli
Copy link
Contributor Author

wyli commented Mar 15, 2022

not sure if I understand it correctly, I updated #3482 to-do list with a link to this ticket.

wyli added a commit that referenced this issue Mar 21, 2022
@wyli
3942 3966 adds _requires_ and import support (#3945)
ec19406 
* fixes #3942

Signed-off-by: Wenqi Li <[email protected]>

* adds import statement

Signed-off-by: Wenqi Li <[email protected]>

* more tests

Signed-off-by: Wenqi Li <[email protected]>

* update to resolve import statement

Signed-off-by: Wenqi Li <[email protected]>

* update based on comments

Signed-off-by: Wenqi Li <[email protected]>

* update

Signed-off-by: Wenqi Li <[email protected]>

* update based on comments

Signed-off-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wyli wyli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3942 3966 adds _requires_ and import support wyli/MONAI
2 participants
@wyli @Nic-Ma