-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impossible to translate sorting labels from Facetedsearch module #35237
Impossible to translate sorting labels from Facetedsearch module #35237
Comments
Hello @Prestaworks , I reproduce the issue with PrestaShop version Screen.Recording.2024-02-01.at.15.58.05.movPlease be aware that some issues might take a very long time to be resolved. If this one is important to you and you cannot wait for it to be fixed on the project’s own time, we strongly suggest you consider contacting a professional to help you. If you fix the issue on your end, please contribute it back to the project. Remember that the more people contribute, the better PrestaShop becomes for everyone. Thank you |
ok, so the module can't be 100% translated for earlier versions than an unreleased version and that is fine? If so, go ahead and close the report and close the PR. |
@Prestaworks Yeah, sucks, but that's how it is. It's the same situation with other strings and other modules. The same problem was with "Available" value in filters.
You can work around it quite easily, if you know:
|
Yeah I know, I can solve it, you too, but the average merchant can't :( Maybe the best thing would be to redo the translations so there are no dividing between modules/front/BO and just all domains from all files are displayed in a big tree list. Would probobly be easier to find what you are looking for that way. |
@Prestaworks Well, I try to convince somebody from the maintainer team for years to solve this, that it's an important flaw, but haven't been successful. 🤷♂️ |
I don't know the translation system well enough, but I'd guess the limitation is because the UX favors using the XLF default catalog because scanning aaaallll the code would be too long every time you need to translate something. That said I agree with you that it's a pain that we can't edit wordings as long as the default catalog is not updated, maybe we could handle a systematic/automatic scan of all the files but then it should be cached. So the first init would take a while (potentially 1 or 2 minutes I'm not sure) but then you have it all. And when some new wordings are added you just need to clear the cache, but since new wordings are likely to come with update modules or update core these operations are already followed by a cache clear so it could work. |
Sounds like a good way to handle it @jolelievre |
@Hlavtox, it's something I want to improve. However, as you know @Hlavtox, there are many ideas and issues for a few project members. I'm considering whether it's worth investing in a dedicated search instead of loading all the data for specific translation.
|
@MatShir I don't understand what you are saying. The solution is this:
|
I made a little test on Translations in PHP file$a = $this->trans('TESTPHP', [], 'Modules.Newproducts.Shop'); ✅ Translatable using module translations Translation in
|
Prerequisites
Describe the bug and add attachments
In Facetedsearch module, there are labels for selecting sort order in product list.
Sales, highest to lowest, Relevance, Name, A to Z and so on.
Some of these are missing translations, like Reference, A to Z for instance and it is not listed in the BO.
The reason for this is that the labels loaded from the module are connected to the translation domain Shop.Theme.Catalog
Expected behavior
It should be possible to select faceted search module in translations and change these labels.
Steps to reproduce
PrestaShop version(s) where the bug happened
8.1.3
PHP version(s) where the bug happened
8.1.12
If your bug is related to a module, specify its name and its version
facetedsearch 3.14.1
Your company or customer's name goes here (if applicable).
Prestaworks AB
The text was updated successfully, but these errors were encountered: