fix: siliconflow error response #636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sternelee
force-pushed
the
fix/siliconflow
branch
from
e9f9f2f to
31a54be
Compare
VisargD
previously approved these changes
Oct 1, 2024
|
Hey! Will it be possible to add the documentation link in the PR description to point out why this is required? It will make it easy to track things in future. Thanks! |
narengogi
requested changes
Oct 24, 2024
| } | ||
|
|
||
| return response; | ||
| return response as ChatCompletionResponse; |
There was a problem hiding this comment.
would recommend changing the structure of this function to
if ('contents' in response) {
return response
}
if (responseStatus !== 200 && typeof response === 'string') {
return SiliconFlowErrorResponseTransform(
{ message: response, code: String(responseStatus) },
SILICONFLOW
);
}
else return generateInvalidProviderResponseError(response, SILICONFLOW)
There was a problem hiding this comment.
Same comment for other updated functions as well
|
Moving this PR to draft state. Please make it ready for review one the comment is addressed. #636 (comment) |
|
Closing this PR due to inactivity. Please feel free to reopen whenever required. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
silliconflow API error response only received message text, not a object