From 163cc8e6875b55e1dab8743fadee8501d98103db Mon Sep 17 00:00:00 2001 From: Mathias-Boulay Date: Sat, 25 Jan 2025 23:19:33 +0100 Subject: [PATCH] fix(modpack): installs being broken when installing multiple versions --- .../modloaders/modpacks/api/ModpackInstaller.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/modloaders/modpacks/api/ModpackInstaller.java b/app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/modloaders/modpacks/api/ModpackInstaller.java index 49b1f6f2f0..048458d30a 100644 --- a/app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/modloaders/modpacks/api/ModpackInstaller.java +++ b/app_pojavlauncher/src/main/java/net/kdt/pojavlaunch/modloaders/modpacks/api/ModpackInstaller.java @@ -21,7 +21,14 @@ public class ModpackInstaller { public static ModLoader installModpack(ModDetail modDetail, int selectedVersion, InstallFunction installFunction) throws IOException { String versionUrl = modDetail.versionUrls[selectedVersion]; String versionHash = modDetail.versionHashes[selectedVersion]; - String modpackName = modDetail.title.toLowerCase(Locale.ROOT).trim().replace(" ", "_" ); + String modpackName = (modDetail.title.toLowerCase(Locale.ROOT) + " " + modDetail.versionNames[selectedVersion]) + .trim().replaceAll("[\\\\/:*?\"<>| \\t\\n]", "_" ); + if (versionHash != null) { + modpackName += "_" + versionHash; + } + if (modpackName.length() > 255){ + modpackName = modpackName.substring(0,255); + } // Build a new minecraft instance, folder first