Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dropdown open logic (intervention and site dropdown) #2355

Open
mohitb35 opened this issue Jan 9, 2025 · 0 comments
Open

Refactor dropdown open logic (intervention and site dropdown) #2355

mohitb35 opened this issue Jan 9, 2025 · 0 comments
Assignees
@shyambhongle

Comments

@mohitb35
Copy link
Collaborator

mohitb35 commented Jan 9, 2025 

          The logic to keep only one menu open is unclear, partly due to using terms like `enable` and `disable` instead of `open`/`close`/`toggle`. The names `disableInterventionMenu`, `enableInterventionFilter`, `disableInterventionFilter` need rethinking.

Please revisit this logic across the ProjectSiteDropdown, InterventionDropdown, ProjectsContext and MapControls

Originally posted by @mohitb35 in #2343 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shyambhongle shyambhongle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shyambhongle @mohitb35