-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Axios Error - Twitch Component Won't Execute Due to Error #4565
Comments
Hi @clarkio, Thank you for reporting this issue, I am able to recreate it we will prioritize this to be fixed. Please follow this ticket for updates. |
Thank you so much for the detailed report and breakdown, @clarkio! FYI since it looks like you were in the component code, we're happy to review a PR if you're interested in implementing the fix yourself, otherwise our team will take a look soon. |
@dannyroosevelt thanks and yea I'd be happy to but I see there is a PR open which I'm also happy to see 👍 |
Oops looks like we jumped the gun on it... but it's in the QA queue, so it should be fixed soon! |
No worries. Glad to see it's moving along quickly and will be resolved |
@clarkio TestPassed |
This is great to see. Does it mean it's been published to the platform now as well? @Hassan-Abbas-SQA @lcaresia @dannyroosevelt |
@clarkio Yes, it's published! |
@lcaresia great to hear. Is there anything I need to do in my workflows to get it updated? I noticed the error still showing up when I tried earlier. |
Yes, you need to remove the action and create again! If you still having the problem call me on Slack and I will help you |
@clarkio you actually don't need to remove the action from your workflow -- you should see a red button at the top right of the Twitch step that says "Update". |
@dannyroosevelt oh whew ok that sounds much better. However I did just manually update by removing some steps and re-adding them and it's working now. I'll use what you suggested @dannyroosevelt to update other workflows using this component. |
@dannyroosevelt I'm not seeing that option in my workflows. Here is an example: |
Hey @clarkio that's strange. We aren't able to reproduce that issue. Can you try refreshing the page? If you still don't seen a prompt to Update the action, can you visit the settings for that workflow and enable the toggle to Share with Support, then paste the workflow URL so I can check it out? |
Actually, we were able to reproduce the error and we're looking into it. In the meantime if you want to get the action working asap, you can definitely remove that step and add it again. |
FYI we've identified the issue and confirmed it's not related to this Twitch update. We are tracking the issue re: not getting prompted to update existing actions here. |
FYI @clarkio this should be fixed -- you should now be able to update actions normally |
Awesome and thanks for sharing the update 🙂👍 |
Describe the bug
Using any of the Twitch components results in the action failing due to an error with Axios. After further investigation of the error I believe it's due to a recent change to the axios package which is noted in this issue in the Axios repo: axios/axios#5142. This seems to require some changes to what's provided in the configuration object to the axios package - specifically the
paramsSerializer
option. This option requires a new key calledencode
.To Reproduce
Steps to reproduce the behavior:
Expected behavior
Twitch actions to execute requests and return a result
Screenshots
Desktop (please complete the following information):
Additional context
Axios seems to have made an update that's a breaking change based on this issue in their repo:
I believe this function in the pipedream Twitch component code needs to be updated:
pipedream/components/twitch/twitch.app.mjs
Line 53 in bdb6a86
This issue for the Axios docs covers what I believe needs to change: axios/axios-docs#90
Before:
After:
The text was updated successfully, but these errors were encountered: