Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect gold value for common armor and weapon #4

Open
Pierre-Sassoulas opened this issue Aug 21, 2019 · 2 comments
Open

Incorrect gold value for common armor and weapon #4

Pierre-Sassoulas opened this issue Aug 21, 2019 · 2 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Pierre-Sassoulas
Copy link
Owner

Pierre-Sassoulas commented Aug 21, 2019

It seems that the WOW API does not give the real vendor value with getItemInfo(). It even gives an item link with wrong value for gold. (64 copper for a 2s99c item).

It's a bug, but I think it's in the WOW API, so I don't know how to fix it right now.

Affect only common weapon/armor, so it only affects the very low level players, because later weapon and armor are grey or green but rarely white.

I don't think I'll take more time for this, but PR welcome :)

@Pierre-Sassoulas Pierre-Sassoulas added bug Something isn't working wontfix This will not be worked on labels Aug 21, 2019
@Pierre-Sassoulas
Copy link
Owner Author

Removed it in 0.3.1 because it was annoyingly breaking the feature for grey items.

@Pierre-Sassoulas
Copy link
Owner Author

Maybe reintroduced in 0.6.0 if they are in scrap junk list (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant