Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit the WgManager class #10

Open
CyrilBrulebois opened this issue Aug 23, 2024 · 0 comments
Open

Revisit the WgManager class #10

CyrilBrulebois opened this issue Aug 23, 2024 · 0 comments

Comments

@CyrilBrulebois
Copy link
Collaborator

It might have been a mistake to have 3 mandatory parameters when creating a WgManager instance… those could be re-read from the existing config (if there's one), instead of having to be passed every single time.

See ffc9c16 which made this design issue obvious.

Similar issues might show up when the pirogue-admin server and its gRPC interface are implemented, that can be revisited at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant