Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid missunderstanding how to use ADB Command (design improvement) #4

Open
flohall opened this issue Oct 14, 2018 · 0 comments
Open

Comments

@flohall
Copy link

flohall commented Oct 14, 2018

First A big thank you for your great work.
I want to suggest a little improvement for the keyboardswap2 plugin.

Problem in short:
For me (I am not an android developer) it was not obvious that I have to put a SPACE between keyboardswap2 and android in the pm grant command for adb shell. I found out this after checking how the manifest file (out of source code) is structured, but maybe other users will give up faster.

More details about the problem:
In the keyboardswap2 plugin instructions under no 4 the command looks like it is quite long and that there is just a linewrap. It is not easy to recognize that there should be a SPACE at the end of the line. But the correct command is:
pm grant keepass2android.plugin.keyboardswap2 android.permission.WRITE_SECURE_SETTINGS
Maybe this issue is only crucial on some devices with special screen width. I use Huawei P10.

Hard and Software used
Huawei P10
VTR-L09
EMUI-Version: 8.0.0
Android-Version: 8.0.0
Screen: 1920*1080

Possible solutions:

  • make it possible to copy the command text (to send it to a computer e.g. via chat or other apps)
  • put a special character or background color for all spaces and explain this in the instructions
  • just put a hint in the instructions that there must be a SPACE between keyboardswap2 and android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant