Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBC: Blead Breaks Perl::Critic::Pulp #22565

Closed
cjg-cguevara opened this issue Sep 2, 2024 · 3 comments
Closed

BBC: Blead Breaks Perl::Critic::Pulp #22565

cjg-cguevara opened this issue Sep 2, 2024 · 3 comments
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) Closable? We might be able to close this ticket, but we need to check with the reporter

Comments

@cjg-cguevara
Copy link

This is a bug report for perl from "Carlos Guevara" [email protected],
generated with the help of perlbug 1.43 running under perl 5.41.4.


BBC: Blead Breaks Perl::Critic::Pulp

Please see http://fast-matrix.cpantesters.org/?dist=Perl::Critic::Pulp


Flags

  • category=core
  • severity=low

Perl configuration

Site configuration information for perl 5.41.4:

Configured by cpan at Mon Sep  2 12:37:30 EDT 2024.

Summary of my perl5 (revision 5 version 41 subversion 4) configuration:
  Commit id: 053b4620bf8cf1d7a4b0edcb6a587b46a38f7d32
  Platform:
    osname=linux
    osvers=5.14.0-427.33.1.el9_4.x86_64
    archname=x86_64-linux
    uname='linux cjg-rhel9 5.14.0-427.33.1.el9_4.x86_64 #1 smp preempt_dynamic fri aug 16 10:56:24 edt 2024 x86_64 x86_64 x86_64 gnulinux '
    config_args='-des -Dprefix=/home/cpan/bin/perl -Dscriptdir=/home/cpan/bin/perl/bin -Dusedevel -Duse64bitall'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=undef
    usemultiplicity=undef
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
  Compiler:
    cc='cc'
    ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
    optimize='-O2'
    cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion=''
    gccversion='11.4.1 20231218 (Red Hat 11.4.1-3)'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib /usr/lib64 /usr/local/lib64
    libs=-lpthread -ldb -ldl -lm -lcrypt -lutil -lc
    perllibs=-lpthread -ldl -lm -lcrypt -lutil -lc
    libc=/lib/../lib64/libc.so.6
    so=so
    useshrplib=false
    libperl=libperl.a
    gnulibc_version='2.34'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'


---
@INC for perl 5.41.4:
    /home/cpan/bin/perl/lib/site_perl/5.41.4/x86_64-linux
    /home/cpan/bin/perl/lib/site_perl/5.41.4
    /home/cpan/bin/perl/lib/5.41.4/x86_64-linux
    /home/cpan/bin/perl/lib/5.41.4

---
Environment for perl 5.41.4:
    HOME=/home/cpan
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LC_ALL=C
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/cpan/bin/perl/bin:/home/cpan/bin:/usr/share/Modules/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin
    PERL_BADLANG (unset)
    SHELL=/bin/bash
@Leont
Copy link
Contributor

Leont commented Sep 2, 2024

This seems to be caused by #22507: !ref($log_file) ne '-'. Looks like a true positive to me (so it should be fixed in Perl::Tidy).

@jkeenan jkeenan added BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) and removed Needs Triage labels Sep 3, 2024
@jkeenan
Copy link
Contributor

jkeenan commented Sep 17, 2024

Perl::Critic::Pulp is once again passing its tests on CPANtesters; see
home. So I'm labeling this ticket Closable.

@jkeenan jkeenan added the Closable? We might be able to close this ticket, but we need to check with the reporter label Sep 17, 2024
@mauke
Copy link
Contributor

mauke commented Sep 17, 2024

This was fixed in https://metacpan.org/release/SHANCOCK/Perl-Tidy-20240903, more specifically perltidy/perltidy@aea80e0. Closing.

@mauke mauke closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BBC Blead Breaks CPAN - changes in blead broke a cpan module(s) Closable? We might be able to close this ticket, but we need to check with the reporter
Projects
None yet
Development

No branches or pull requests

4 participants