Macro CellarStaking Audit Discussion

[kkennis]

See: https://www.notion.so/0xmacro/High-Old-stakers-can-run-away-with-all-rewards-of-the-new-reward-cycle-e2b82c87e745439399286fab9a666bc7

[Informational] Rewards can remain un-utilized is a won't fix.

Comment: This is a common issue around many staking contracts and fixing it would require more added complexity to staking/unstaking than benefit. In practice, we don't expect this to happen since during an active reward program there is always an incentive to deposit. If this ever were to occur, any un-utilized rewards could be covered by scheduling a new reward program in notifyRewardAmount to re-distribute them.

[Informational] There is a loss of precision in rewardRate calculation is a won't fix.

Comment: potential loss of precision has been noted in the natspec, on line 571, since the time of implementation. Furthermore, this is a risk to administrators, not users, and administrators are more likely to be aware of the finer details of how the contract works. In practice, the reward amounts and epoch durations we have discussed would not be affected by loss of precision.