Fix crash when multiple tabs open and logging out in one of them

[Powersource]

Related links

IdentityModel/oidc-client-js#49
IdentityModel/oidc-client-js#168
IdentityModel/oidc-client-js#830
#162

Doing this IdentityModel/oidc-client-js#830 (comment) (note it's supposed to be signinSilent not signInSilent) right after setting up our userManager at first seemed to have fixed the issue, but then made me run into errors including crashing the page with "Unhandled Rejection (Error): invalid_grant" (thrown by oidc-client).

[aerugo]

Those errors only happen when we log out manually, correct? If so, that bug is an acceptable trade-off for now.

[Powersource]

Yep. Reproduction:

• Log in in one tab (tab 1).
• Open another tab (tab 2), you are automatically logged in there.
• Log out in tab 2 (although other way around works as well).
• Refresh tab 1, crash.

[Powersource]

Merged now

[Powersource]

Tried adding a .catch for the error and that stops the instant crashing but instead makes the user crash when they try to perform something that requires auth, which is probably worse.

[Powersource]

Some clues in this documentation issue but even they seem confused IdentityModel/oidc-client-js#339

Just do a signinSilent before you even think about calling getUser. If it resolves, the User you get immediately after is valid; if it rejects you need to do an interactive login e.g. with signinRedirect.

The querySessionStatus method on UserManager may be able to give complete status information, but it performs a callback to silent_redirect_uri that has a very different query than signinSilent, and somehow while I was doing that I didn't think to pass that to signinSilentCallback (probably because I hadn't figured out that the different URLs MUST be distinct and was trying to detect based on the query). But it seems silly to do a querySessionStatus which does almost the same thing as a signinSilent but might have to be followed by a signinSilent anyway.

... But I've also seen cases where signinSilent seems to generate a user with invalid tokens, so I think I'm still missing something here.

[Powersource]

TODO: try IdentityModel/oidc-client-js#830 (comment)

[Powersource]

Closing this through #196 now and putting my future faith in #195

[Powersource]

oh and fwiw I realized that the "crash" in the title here was only in dev, it was an uncaught promise and that I guess crashes the dev react renderer but not in prod. Either way it's getting caught now.