Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package syncfusion_flutter_datepicker 24.2.4 to 24.2.7. #2401

Closed
palisadoes opened this issue Feb 26, 2024 · 6 comments
Closed

Upgrade package syncfusion_flutter_datepicker 24.2.4 to 24.2.7. #2401

palisadoes opened this issue Feb 26, 2024 · 6 comments
Assignees
Labels
bug Something isn't working security Security fix

Comments

@palisadoes
Copy link
Contributor

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

Upgrade package syncfusion_flutter_datepicker 24.2.4 to 24.2.7.

Background Failing PRs

Release Note Details

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@palisadoes palisadoes added bug Something isn't working security Security fix labels Feb 26, 2024
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Feb 26, 2024
@Cioppolo14 Cioppolo14 removed the unapproved Unapproved, needs to be triaged label Feb 26, 2024
@ArinNigam
Copy link
Contributor

@Cioppolo14 @palisadoes Can you assign me this issue?

@ArinNigam
Copy link
Contributor

  • So I tried fixing the package syncfusion_flutter_datepicker to 24.2.7 but workflow is failing and giving the error
image
  • I tried looking online why this error is coming and I came to conclusion that it may be a sdk problem which is currently at 3.16.0. I tried to test codebase with 3.19.0 in my system and all test cases passed
image

Releases in flutter 3.19
https://docs.flutter.dev/release/breaking-changes/key-event-migration

image

Conclusion
So I am guessing that we'll have to migrate the project to flutter sdk 13.9.0 before to fix this issue since the pacakge syncfusion_flutter_datepicker is using date_picker that invokes this HardwareKeyboard.instance which is a part of flutter sdk 13.9.0

image i) syncfusion_flutter_datepicker 24.2.4 image ii) syncfusion_flutter_datepicker 24.2.7

@Cioppolo14 requesting for review

@palisadoes
Copy link
Contributor Author

We have an issue to upgrade to the latest SDK here. Are you willing to work on that too?

@ArinNigam
Copy link
Contributor

@palisadoes yeah sure I can try that but I ran with some errors when I tried working on it before. It seems a lot of code needs to be changed for that. You can assign me though I'll try and get back at it.

@palisadoes
Copy link
Contributor Author

You'll have to comment on the issue to be assigned

@ArinNigam
Copy link
Contributor

This issue is resolved in the PR #2413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security Security fix
Projects
None yet
Development

No branches or pull requests

3 participants