Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for database_mutation_functions.dart #2144

Closed
palisadoes opened this issue Nov 26, 2023 · 10 comments · Fixed by #2285
Closed

Write tests for database_mutation_functions.dart #2144

palisadoes opened this issue Nov 26, 2023 · 10 comments · Fixed by #2285
Assignees
Labels
good first issue Good for newcomers test Testing application unapproved Unapproved, needs to be triaged

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Nov 26, 2023

The Talawa code base needs to be 100% reliable. This means we need to have 100% unittest code coverage. No functionality must be removed to achieve this goal.

We will need unittests done for all methods, classes and functions found in this file.

Any widgets referenced in this file must also have unittests done

lib/services/database_mutation_functions.dart

The current code coverage for this file can be found here:

@palisadoes palisadoes added good first issue Good for newcomers test Testing application labels Nov 26, 2023
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Nov 26, 2023
@imshivam-gupta
Copy link
Contributor

imshivam-gupta commented Dec 4, 2023

@palisadoes @noman2002 I would like to work on this issue.. can you please assign it to me?

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 15, 2023
@Cioppolo14
Copy link
Contributor

@imshivam-gupta Would you still like this issue once one of your other issues is completed?

@imshivam-gupta
Copy link
Contributor

Yes Sure @Cioppolo14

@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 17, 2023
@imshivam-gupta
Copy link
Contributor

imshivam-gupta commented Dec 19, 2023

@Cioppolo14 Can you assign me this issue. Since I have already created a PR for one issue and the other issue is solved already because the coverage was 99%. Both of these will be closed as soon as maintainers check the pr and issue thread. I checked that this file has 0.5% coverage so this needs to be worked upon so that code coverage can actually be increased.

@imshivam-gupta
Copy link
Contributor

@Kevoniat You can close this issue since this issue is duplicate and already closed.

@Dante291
Copy link
Contributor

Dante291 commented Dec 23, 2023

duplicate issue of this issue is closed already, this file has 5.5% coverage and needs to be covered.

@Cioppolo14
Copy link
Contributor

@imshivam-gupta This issue still needs to be completed, @Dante291 is correct it only had 5.5% coverage.

@imshivam-gupta
Copy link
Contributor

Ok I got it @Cioppolo14. I will start working on it as soon as i finish other 2 issues.

@imshivam-gupta
Copy link
Contributor

imshivam-gupta commented Dec 25, 2023

@Cioppolo14 @noman2002 Can you assign this issue to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application unapproved Unapproved, needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants