Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade package lint from 2.1.2 to 2.2.0 #2111

Closed
palisadoes opened this issue Nov 17, 2023 · 7 comments · Fixed by #2118
Closed

Upgrade package lint from 2.1.2 to 2.2.0 #2111

palisadoes opened this issue Nov 17, 2023 · 7 comments · Fixed by #2118
Assignees
@asasmit
Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers security Security fix

Comments

@palisadoes
Copy link
Contributor

For security purposes, we need to bump package lint from 2.1.2 to 2.2.0.

This was attempted as a PR by dependabot

However, the checks failed:

Goals:

  • You will need to update the package and make sure the tests pass, with the file in question getting to 100% test coverage.
  • Functionality must remain unchanged as a result of completing this issue
@palisadoes palisadoes added bug Something isn't working good first issue Good for newcomers security Security fix labels Nov 17, 2023
@github-actions github-actions bot added question Further information is requested test Testing application unapproved Unapproved, needs to be triaged labels Nov 17, 2023
@palisadoes palisadoes added dependencies Pull requests that update a dependency file and removed question Further information is requested test Testing application labels Nov 17, 2023
@vaidic-dodwani
Copy link
Contributor

Hello, I'm eager to work on this issue. Could you please assign it to me?

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Nov 18, 2023
@vaidic-dodwani vaidic-dodwani mentioned this issue Nov 20, 2023
Merged
@github-actions GitHub Actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Nov 29, 2023
@palisadoes palisadoes changed the title Upgrade package Bump lint from 2.1.2 to 2.2.0 Upgrade package lint from 2.1.2 to 2.2.0 Nov 30, 2023
@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 1, 2023
@github-actions GitHub Actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 12, 2023
@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity

@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 16, 2023
@asasmit
Copy link

asasmit commented Dec 16, 2023

Hello, I want to work on this issue. Could you please assign this to me?

@asv018
Copy link

asv018 commented Dec 19, 2023

Hello can you assigned this issue to me
I am eager to work upon this.

@asasmit
Copy link

asasmit commented Dec 23, 2023

@palisadoes @Cioppolo14 Lint package is already upgraded to 2.2.0 version. You can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asasmit asasmit

Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers security Security fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Edit: Made changes to follow the custom lints patter and updates the … vaidic-dodwani/talawa
4 participants
@palisadoes @vaidic-dodwani @asasmit @asv018