Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMongo: Inconsistencies in graphql schema #2852

Closed
Nikhilh26 opened this issue Jan 13, 2025 · 11 comments
Closed

NoMongo: Inconsistencies in graphql schema #2852

Nikhilh26 opened this issue Jan 13, 2025 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@Nikhilh26
Copy link

Describe the bug
After setting up talawa-admin and talawa-api there alot of inconsistencies in graphql schema in the frontend and the backend schema
To Reproduce
Steps to reproduce the behavior:

  1. Start the talawa-admin on develop-postgres branch
  2. Start the talawa-api on develop-postgres branch
  3. Try to signup as user/admin

Expected behavior
We should be able to signup

Actual behavior
Errors are thrown which depict inconsistency in the schema

Screenshots
If applicable, add screenshots to help explain your problem.

Additional details
Screenshot 2025-01-13 190201

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@Nikhilh26 Nikhilh26 added the bug Something isn't working label Jan 13, 2025
@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Jan 13, 2025
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@Nikhilh26
Copy link
Author

Nikhilh26 commented Jan 13, 2025

I have identified the incosistencies. I can start working on it , but i had few doubts.

  1. Do we need confirmedPassword in the talawa-api( I skimmed through files and i don;t think we are storing or using the confirmedPassword anywhere) .
  2. From talwa-admin we are sending the orgId but in the talawa-api graphql schema we have not defined it . So , do we need that ?

@palisadoes
Copy link
Contributor

  1. Check the develop branch to answer some of your queries.
  2. Most queries should include the orgID, refer to develop to validate.
  3. @xoldd Can you provide context?

@xoldd
Copy link
Contributor

xoldd commented Jan 14, 2025

@Nikhilh26 you're meant to fix the graphql schema on the client side to match them with what's implemented on the api side. The inconsistency is on talawa-admin, so fix that.

There is no need for an organization id on a user sign up because the users are a global entity like organizations and don't have to be tied to any organization for them to sign up. Once they've signed up they can choose the organization they want to join.

@palisadoes
Copy link
Contributor

@xoldd Thanks for the reminder. Closing.

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in NoMongo: Talawa-API Jan 14, 2025
@Nikhilh26
Copy link
Author

Nikhilh26 commented Jan 14, 2025

While signing up , users and admins both are asked about the organization should that be removed as well from the UI?
image

@Nikhilh26
Copy link
Author

@xoldd
In api we have marked confirmed password as required here and in develop we were not using it
develop

@xoldd
Copy link
Contributor

xoldd commented Jan 14, 2025

@Nikhilh26 Confirmed password is technically a UX only thing. Removed it in this pull request: #2858

@xoldd
Copy link
Contributor

xoldd commented Jan 14, 2025

While signing up , users and admins both are asked about the organization should that be removed as well from the UI?

Yes. The organizations a user is an administrator member of is inferred from their identity when they sign in or sign up. If they aren't an administrator member of any organization, they shouldn't see any organizations to manage on talawa admin.

@Nikhilh26
Copy link
Author

So we will have to remove it from the api ql right?

@Nikhilh26
Copy link
Author

Hey can we maybe connect on slack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants