Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all non-test Typescript files have < 600 lines - Admin #1298

Closed
palisadoes opened this issue Dec 27, 2023 · 9 comments
Closed

Ensure all non-test Typescript files have < 600 lines - Admin #1298

palisadoes opened this issue Dec 27, 2023 · 9 comments
Assignees

Comments

@palisadoes
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Our GitHub action countline.py script is not sufficiently effective as deployed

We need to also restore our goal of having no typescript files with > 600 lines of code. We do this for readability and to force better coding standards by encouraging the use of more reusable code.

Describe the solution you'd like
A clear and concise description of what you want to happen.

  1. Update our pull request GitHub action to make the countline.py script fail for files with > 600 lines of code. Run the ./countline.py --help command to see how that is done.
  2. Run the countline.py script with the 600 line limit to identify the offending files.
  3. Refactor the code in the offending files so that the script does not fail.
    Describe alternatives you've considered
    A clear and concise description of any alternative solutions or features you've considered.

Approach to be followed (optional)

  • See above

Additional context

  • Please work with @noman2002 in reviewing your PR

Potential internship candidates

@Gmin2
Copy link
Contributor

Gmin2 commented Dec 27, 2023

can i work on it?

@dhiraj0911
Copy link
Contributor

I'd like to work on this

@AVtheking
Copy link
Contributor

Please assign me this issue

Copy link

github-actions bot commented Jan 7, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 7, 2024
@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity

@Sauradip07
Copy link
Contributor

@palisadoes can i work on it?

@nimishmedatwal
Copy link

nimishmedatwal commented Jan 7, 2024

@palisadoes Can you assign this issue to me? I've worked on something similar and I think I can resolve this issue.

@Sauradip07
Copy link
Contributor

I am currently working on an issue to reduce the number of lines of code in some of our TypeScript (.ts) and TypeScript JSX (.tsx) files. The goal is to bring these files, which currently exceed 600 lines of code, down to a more manageable size of 600 lines.

There are 4 specific files that I am focusing on at the moment. I've attached pictures below for your reference.
Screenshot from 2024-01-13 23-10-21

@palisadoes palisadoes reopened this Jan 13, 2024
@palisadoes
Copy link
Contributor Author

  1. Merge your code with the latest upstream
  2. Reopen a PR
  3. Make sure the only files updated are typescript files that are over 600 lines in length. They must also be tsdoc compliant.
  4. Your last PR submitted no files relevant to the issue. Please be more vigilant in your submission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants