Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify all listeners when the Cardoteka.reload method is called #8

Open
PackRuble opened this issue Dec 13, 2023 · 2 comments
Open
Labels
invalid This doesn't seem right
Milestone

Comments

@PackRuble
Copy link
Owner

Sequencing:

  1. Save the value in SharedPreferences via native platforms
  2. Call the SharedPreferences.reload method as required by documentation:

If you need to read a preference value that may have been changed by anything other than the SharedPreferences instance you are reading it from, you should call reload() on the instance before reading from it to update its cache with any external changes.

  1. We expect watcher to notify all cards with new values (this doesn't happen)
@PackRuble PackRuble added the invalid This doesn't seem right label Dec 13, 2023
@PackRuble
Copy link
Owner Author

It seems this would require implementing the notifyAll method, since we don't have access to the list of callbacks...

@PackRuble
Copy link
Owner Author

Related to #17

@PackRuble PackRuble modified the milestones: v1.1.0, v2.0.0 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant