Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't show jwt secret if show option is false even if the key is updated #275

Merged
merged 1 commit into from
Jan 25, 2025
Merged

don't show jwt secret if show option is false even if the key is updated #275

merged 1 commit into from
Jan 25, 2025

Conversation

kbiits
Copy link
Contributor

@kbiits kbiits commented Jan 7, 2025

Description

Fixes #274
Adding a new option in jwt secret generator command for not showing the newly generated key.

Checklist:

  • I've added tests for my changes or tests are not applicable
  • I've changed documentations or changes are not required
  • I've added my changes to CHANGELOG.md

@mfn mfn mentioned this pull request Jan 7, 2025
Closed
@kbiits kbiits force-pushed the main branch 2 times, most recently from e293b58 to 2e4041d Compare January 7, 2025 14:06
mfn
mfn approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@mfn mfn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Confusingly, ->displayKey() also did this:

$this->laravel['config']['jwt.secret'] = $key;

Apparently for not much reason I believe though.

@Messhias Messhias merged commit 873de1f into PHP-Open-Source-Saver:main Jan 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Messhias Messhias Messhias approved these changes

@mfn mfn mfn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate Secret Command - add option to not showing the key if it's updated
3 participants
@kbiits @mfn @Messhias