Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burnout 3/Revenge/Dominator - Sun Glow Can Be Seen Through Surfaces #883

Closed
escape209 opened this issue Oct 7, 2015 · 19 comments · Fixed by #7267
Closed

Burnout 3/Revenge/Dominator - Sun Glow Can Be Seen Through Surfaces #883

escape209 opened this issue Oct 7, 2015 · 19 comments · Fixed by #7267

Comments

@escape209
Copy link
Contributor

This is a known issue, but I'm opening this issue here so that if there is any progress on it being fixed, then it can be posted here and eventually (hopefully) marked as solved, in addition to the fact that it hasn't been mentioned on the issue tracker yet.

Anyway, this bug seems to be a core bug, as it appears in all of GSdx's software and hardware renderers, as well as in ZeroGS. It's a pretty easy issue to understand - you can see the sun through walls, when it should disappear when your view of it is completely (not partially) obscured by an object. The bug happens in Burnout 3: Takedown, Burnout Revenge and Burnout Dominator, of which the versions for all regions are affected (basically, PAL and NTSC.)

No combination of settings in the Emulation settings window, nor the GSdx settings window has been able to fix the bug (including Synchronized MTGS.)

@FirstRoboticsGuy999
Copy link

In the Burnout games, the issue is clearly related to RenderWare. RenderWare appears to handle post-processing effects differently than most PS2 games. It probably has something to do with Z-sorting and the fact that the PS2 doesn't have depth buffer support.

For me, this happens in games like Gran Turismo 4 as well; but software mode fixes the Sun issue.

I found a great write-up by Matt Godbolt that explains some of the PS2's rendering limitations. http://xania.org/201003/swat-ps2-renderer

Some old RenderWare development docs: http://www.tnlc.com/rw/api/rwdoc.htm

@gregory38
Copy link
Contributor

PS2 has depth support. It misses stencil / color swizzle / shader ... Well it just misses everything.

There is still a bug in SW when doing read/write to a texture so it could still be a GSdx bug. But it could also be a core bug.

@escape209
Copy link
Contributor Author

It seems like it's not the sun that's showing through walls and it's actually just its glow effect. Setting Skipdraw to 28 will remove the sun's glow, meaning it won't show through walls, but it will appear as just a yellow circle in the sky:

Skipdraw 0
gsdx_20160110131542

Skipdraw 28
gsdx_20160110131710

@willkuer
Copy link
Contributor

28?

I never heard such a large value. For 27 you can still see the glow?
Thanks for the hint. This makes support much easier.

@escape209
Copy link
Contributor Author

The glow is indeed still there at 27 😱

@escape209 escape209 changed the title Burnout 3/Revenge/Dominator - Sun Can Be Seen Through Surfaces Burnout 3/Revenge/Dominator - Sun Glow Can Be Seen Through Surfaces Jan 16, 2016
@FlatOutPS2
Copy link
Contributor

This issue has recently been solved for software mode thanks to a123e65

It still affects the hardware modes though.

@jcdenton2k
Copy link

Wanted to mention that the 'Sun Rays' would appear through buildings/walls in FF12 as well. It didn't bother me enough to post about it but it has been an ongoing issue since forever.

I'll test out with software mode and report back with details if needed.

@RedDevilus
Copy link
Contributor

Seems to still be a problem in HW mode and SW as always works well.

@jeremybris
Copy link

jeremybris commented Feb 27, 2022

@refractionpcsx2
Copy link
Member

Does this still happen in recent 1.7 builds? if it does can we get a GS Dump?

@Mrlinkwii
Copy link
Contributor

burnout light though object.zip
heres a GS dump 🙂

@JimScript
Copy link
Contributor

Lego Racers 2 has the same problem as well:
gs_20220710100117_LEGO Racers 2_SLUS-20042
GS Dump:
gs_20220710095656_LEGO Racers 2_SLUS-20042.zip
gs_20220710100711_LEGO Racers 2_SLUS-20042
GS Dump:
gs_20220710100711_LEGO Racers 2_SLUS-20042.zip

Thing is, switching to software doesn't immediately get rid of it(as seen in the GS Dumps), it's like there is a culling system in the software mode that isn't in the hardware mode.

@refractionpcsx2
Copy link
Member

Can you make your own thread for that please? It's likely not the same problem (a lot of different things can cause this!). Since it takes a moment to kick in, it probably needs to download the picture to work it out, which means it might not show in the GS dump.

@JimScript
Copy link
Contributor

Right, sorry it looked close enough of a problem to comment, I have made a separate issue here(#6605).

@refractionpcsx2
Copy link
Member

Thanks :)

@twoco
Copy link

twoco commented Jul 29, 2022

@jeremybris Thanks for your list of existing issues or duplicates (If this bug is caused by the same reason). Btw. you have a mistake in your list. For Need for Speed Most Wanted it's #3993.

@refractionpcsx2
Copy link
Member

refractionpcsx2 commented Oct 30, 2022

Can you provide a GS Dump? Because the three I tried, it did.

As I noted, having your resolution too high can break the effect also

@Softernet
Copy link

Everything is fine. There was a misunderstanding due to the Manual Hardware Render Fixes checkbox.

@refractionpcsx2
Copy link
Member

Yeah that would break it too ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.