Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Game loaded using 'Host Filesystem' ignores cheat pnach file. #11533

Open
JpDeathBlade opened this issue Jul 10, 2024 · 4 comments · May be fixed by #12128
Open

[BUG]: Game loaded using 'Host Filesystem' ignores cheat pnach file. #11533

JpDeathBlade opened this issue Jul 10, 2024 · 4 comments · May be fixed by #12128
Labels
Bug Core

Comments

@JpDeathBlade
Copy link

Describe the Bug

I am currently working on a pnach file for Resident Evil: Outbreak File 1. I used THIS guide to extract the game files into a folder, and load the game using an .ELF file. This helps decrease load times when playing the game which is super helpful and the ideal way to play this particular title. When I do this, the cheat menu does not populate with cheats. The log window shows that cheats are found. If I load the same game up as an .ISO the cheat menu populates as expected. I've only tested this with Resident Evil: Outbreak File 1, my assumption is that this happens on other games as well.

Reproduction Steps

  • Follow the OBSRV QuickLoading Guide
    • Open the game .ISO file
    • Extract files to a folder
    • Rename SLPM_654.28 to SLPM_654.28.elf, or use the modified .elf files from the guide
    • Enable Host Filesystem in Settings > Emulation > System Settings
    • Import the .elf file into PCSX2 v1.7
    • Update the Disc Path for the .elf file to point to the original ISO
  • Create a pnach cheat file for the game
    • For this game the filename is "SLPM-65428_32097C02.pnach"
    • Include a cheat, like this one that unlocks "Infinity" mode:
      • [Mode\Infinity]
      • patch=1,EE,20301D7F,byte,00000001
  • Enable Cheats
  • Launch ISO version of the game or Right Click it in the Game List
    • Open Game Properties > Cheats and see the Infinity cheat
  • Launch ELF version of the game or Right Click it in the Game List
    • Open Game Properties > Cheats and the Infinity cheat is NOT loaded.

Note: If you select "Edit Cheats..." from the Tools menu running any version of the game, .ELF or .ISO, it opens the same file.

Expected Behavior

Expected:
This menu when using any version of the game should populate with cheats.
Screenshot 2024-07-10 171609

Actual:
When using a 'Host Filesystem" version of the game, launching from a .ELF, the cheat menu doesn't populate even tho the log says that it found cheats.
Screenshot 2024-07-10 171515

PCSX2 Revision

1.7.5973

Operating System

Windows 11

If Linux - Specify Distro

No response

Logs & Dumps

No response
@CookiePLMonster
Copy link
Contributor

This is not a suggested fix, but I'd like you to check something so I could confirm that your issue is identical to a bug I was reported months ago and could not reproduce it - do the cheats load when you drop the serial from the pnach name, renaming the cheats to 32097C02.pnach?

@JpDeathBlade
Copy link
Author

Do the cheats load when you drop the serial from the pnach name, renaming the cheats to 32097C02.pnach?
They do! Renaming the file has them showing up correctly and they work when toggled.

To add some more details that might be useful: I started testing with other versions of the game and I was able to get it to generate the cheat file by clicking "Edit Cheats..." with different CRCs (for this game it's 32097C02, 32088394, 03C8F393, and C5B37067 so far). If I click the "All CRCs" toggle it will load cheats from all the files BUT only the ones with a matching CRC work. This only effects the CHD/ISO versions. The ELF version ignores the "All CRCs" option and only loads cheats with your suggested change. I think this toggle was causing any existing pnach files to open which is why I couldn't get PCSX2 to generate new ones in my original report.

I can give an example; Here is the Infinity Mode cheat again (I swapped a 2 for a 7 because it should be a bitwise cheat)
[Game Mode\Infinity]
patch=1,EE,70301D7F,extended,00000001

I have this cheat in all three of my pnach files. I gave it a different group/name in each file so it would show up multiple times. If I have "All CRCs" checked, then it will show it multiple times, but it won't actually work when I click on it unless it's from the pnach file with the matching CRC.

@CookiePLMonster
Copy link
Contributor

Thanks! This confirms for me that both are the same issue, that is good to know.

@Mrlinkwii Mrlinkwii added the Core label Jul 14, 2024
CookiePLMonster added a commit to CookiePLMonster/pcsx2 that referenced this issue Dec 27, 2024
@CookiePLMonster
Qt/Patches: Use the game list serial when populating patches for the ELF
9a800fb 
This makes the Game Properties window match the behaviour of the VM
when booting into a game.

Fixes PCSX2#11533
CookiePLMonster added a commit to CookiePLMonster/pcsx2 that referenced this issue Dec 27, 2024
@CookiePLMonster
Qt/Patches: Use the game list serial when populating patches for the ELF
f2488df 
This makes the Game Properties window match the behaviour of the VM
when booting into a game.

Fixes PCSX2#11533
@CookiePLMonster CookiePLMonster linked a pull request Dec 27, 2024 that will close this issue
Open
@CookiePLMonster
Copy link
Contributor

See #12128 for a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patches: Load and list patches for ELFs with a Disc Path set CookiePLMonster/pcsx2
3 participants
@JpDeathBlade @CookiePLMonster @Mrlinkwii