Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fog Tint Applied Twice #747

Open
JohnCorby opened this issue Oct 22, 2023 · 1 comment
Open

Fog Tint Applied Twice #747

JohnCorby opened this issue Oct 22, 2023 · 1 comment
Labels
bug Something isn't working nice to have Features that could be implemented maybe

Comments

@JohnCorby
Copy link
Member

JohnCorby commented Oct 22, 2023

As shown here, we apply fogTint on the property AND tint the fogRamp using fogTint. however, the ramp and tint are also multiplied together in the shader, meaning tint is applied twice.
image

This is analytical and therefore theoretical. I have no screenshot showing this bug to exist. I just want to document it.

Also, I should add better documentation to ramp and tint saying how they are optional and how they override each other.

@JohnCorby JohnCorby added nice to have Features that could be implemented maybe bug Something isn't working labels Oct 22, 2023
@JohnCorby JohnCorby self-assigned this Oct 26, 2023
@xen-42
Copy link
Member

xen-42 commented Oct 6, 2024

Since nobody has brought this up in over a year can we just throw some comments in the code saying its weird and then close this

@JohnCorby JohnCorby removed their assignment Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nice to have Features that could be implemented maybe
Projects
None yet
Development

No branches or pull requests

2 participants