Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring] Update OUDSTheme to get the curent colorScheme to find the suitable token #146

Open
1 task done
ludovic35 opened this issue Oct 2, 2024 · 0 comments
Open
1 task done

[Refactoring] Update OUDSTheme to get the curent colorScheme to find the suitable token #146

ludovic35 opened this issue Oct 2, 2024 · 0 comments
Labels
🧩 enhancement Related to enhancements or feature requests 🔍 triage A new issue that needs to be treated

Comments

@ludovic35
Copy link
Member

ludovic35 commented Oct 2, 2024 •
edited by pylapp
Loading

Prerequisites

As a

Developper

... I want to

get the right token according to the current colorScheme

... so that I can

Avoid to do that type of calls

illustration(for: theme.elevationFocus.elevation(for: colorScheme),

but only this one:

illustration(for: theme.elevationFocus)

Motivation and context

  • Less code to write
  • Use case more simple

Proposed Solution

No response

Other

No response

Contact Details

No response
@ludovic35 ludovic35 added the 🔍 triage A new issue that needs to be treated label Oct 2, 2024
@pylapp pylapp added the 🧩 enhancement Related to enhancements or feature requests label Oct 2, 2024
@pylapp pylapp changed the title [feature]: Update OUDStheme to get the curent colorScheme to find the right token [Refactoring] Update OUDSTheme to get the curent colorScheme to find the suitable token Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧩 enhancement Related to enhancements or feature requests 🔍 triage A new issue that needs to be treated
Projects
[OUDS] Project
Status: Triage
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pylapp @ludovic35 @Tayebsed93